Skip to content

fixing code snippets #7094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 20, 2025
Merged

fixing code snippets #7094

merged 3 commits into from
May 20, 2025
+2 −2

Conversation

@cromewar
Copy link
Contributor

@cromewar cromewar commented May 20, 2025 •
edited by pr-codex bot
Loading

fixing the code snippets for engine cloud docs

PR-Codex overview

This PR updates the import path for the claimTo function from thirdweb/extensions/1155 to thirdweb/extensions/erc1155 and modifies a variable used in a console log statement to correctly reflect the transaction hash.

Detailed summary

  • Changed import path for claimTo from thirdweb/extensions/1155 to thirdweb/extensions/erc1155.
  • Updated the console log statement to use txHash instead of result.transactionHash.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@cromewar cromewar requested review from a team as code owners May 20, 2025 14:36
@changeset-bot
Copy link

changeset-bot bot commented May 20, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: aa67e35

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2025 2:56pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 20, 2025 2:56pm
login ⬜️ Skipped (Inspect) May 20, 2025 2:56pm
thirdweb_playground ⬜️ Skipped (Inspect) May 20, 2025 2:56pm
wallet-ui ⬜️ Skipped (Inspect) May 20, 2025 2:56pm

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 20, 2025
d4mr
d4mr reviewed May 20, 2025
View reviewed changes
.../(app)/team/[team_slug]/[project_slug]/engine/cloud/server-wallets/components/try-it-out.tsx Outdated

const sdkExample = () => `\
import { createThirdwebClient, sendTransaction, getContract, Engine } from "thirdweb";
import {
Copy link
Contributor

@d4mr d4mr May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please get these on 1 line? reads better in the docs that way, otherwise there's a wall of imports first

@graphite-app
Copy link
Contributor

graphite-app bot commented May 20, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@vercel vercel bot temporarily deployed to Preview – wallet-ui May 20, 2025 14:40 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 20, 2025 14:40 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 20, 2025 14:40 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 20, 2025 14:40 Inactive
@codecov
Copy link

codecov bot commented May 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.81%. Comparing base (6cf92c6) to head (aa67e35).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7094   +/-   ##
=======================================
  Coverage   55.81%   55.81%           
=======================================
  Files         900      900           
  Lines       57848    57848           
  Branches     4077     4077           
=======================================
  Hits        32286    32286           
  Misses      25457    25457           
  Partials      105      105
Flag Coverage Δ
packages 55.81% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 56.59 KB (0%) 1.2 s (0%) 472 ms (+120.8% 🔺) 1.7 s
thirdweb (cjs) 304.45 KB (0%) 6.1 s (0%) 1.7 s (+2.88% 🔺) 7.8 s
thirdweb (minimal + tree-shaking) 5.69 KB (0%) 114 ms (0%) 118 ms (+547.31% 🔺) 232 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 61 ms (+430.02% 🔺) 72 ms
thirdweb/react (minimal + tree-shaking) 19.51 KB (-0.04% 🔽) 391 ms (-0.04% 🔽) 214 ms (+222.08% 🔺) 604 ms

@vercel vercel bot temporarily deployed to Preview – login May 20, 2025 14:47 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 20, 2025 14:47 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 20, 2025 14:47 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 20, 2025 14:47 Inactive
d4mr
d4mr approved these changes May 20, 2025
View reviewed changes
.../(app)/team/[team_slug]/[project_slug]/engine/cloud/server-wallets/components/try-it-out.tsx Outdated

const sdkExample = () => `\
import { createThirdwebClient, sendTransaction, getContract, Engine } from "thirdweb";
import {createThirdwebClient, sendTransaction, getContract, Engine} from "thirdweb";
Copy link
Contributor

@d4mr d4mr May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace :)

@joaquim-verges joaquim-verges merged commit 3080a9b into main May 20, 2025
23 checks passed
@joaquim-verges joaquim-verges deleted the engine-cloud-fix branch May 20, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges joaquim-verges approved these changes

+1 more reviewer

@d4mr d4mr d4mr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cromewar cromewar

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cromewar @joaquim-verges @d4mr